1069277 - AppleVTDecoder doesn't compile with non unified build

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

Following bug 1062654, non-unified builds on mac fail.

https://tbpl.mozilla.org/php/getParsedLog.php?id=48370828&tree=Mozilla-Inbound#error0

Error is:
../../../dist/include/nsAutoPtr.h:73:5: error: deleting pointer to incomplete type 'mozilla::AppleFrameRef' may cause undefined behavior [-Werror,-Wdelete-incomplete]
    delete mRawPtr;
    ^      ~~~~~~~
/builds/slave/m-in-osx64-d-nu-00000000000000/build/content/media/fmp4/apple/AppleVTDecoder.cpp:161:5: note: in instantiation of member function 'nsAutoPtr<mozilla::AppleFrameRef>::~nsAutoPtr' requested here
    nsAutoPtr<AppleFrameRef>(static_cast<AppleFrameRef*>(sourceFrameRefCon));
    ^
/builds/slave/m-in-osx64-d-nu-00000000000000/build/content/media/fmp4/apple/AppleVDADecoder.h:28:7: note: forward declaration of 'mozilla::AppleFrameRef'
class AppleFrameRef;
      ^
1 error generated.
make[5]: *** [AppleVTDecoder.o] Error 1
make[4]: *** [content/media/fmp4/target] Error 2
make[4]: *** Waiting for unfinished jobs....

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Do not obfuscate AppleFrameRef

Simplistic solution

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Do not obfuscate AppleFrameRef

re-format one declaration

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62ceb91926f0

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/62ceb91926f0